[windows|toolchain] Try using /Zi by Neumann-A · Pull Request #25692 · microsoft/vcpkg

Neumann-A · 2022-07-11T12:05:00Z

Just testing.

Good example why VCPKG_POST_PORTFILE_INCLUDES would be required

Current status:

Make based ports are a bit screwed and have to restart without parallelism since there is no link job limit
maybe make based ports can be saved by /Fd and some automatic make variable.

scripts/toolchains/windows.cmake

JackBoosY · 2022-07-11T18:09:28Z

https://dev.azure.com/vcpkg/public/_build/results?buildId=74925&view=results

Osyotr · 2022-07-11T18:24:14Z

Here's some information from @BillyONeal regarding /Zi. #20263 (comment)

Neumann-A · 2022-07-11T20:54:15Z

Some form of design description of how the PDB name is set in such a way that ports won't stomp on each other; note that this is not the default.

solved by setting the name explicitly to the portname which is unique

Some form of write-up on how downstream build systems (e.g. cmake using scripts/buildsystems/vcpkg.cmake or the msbuild integration or what have you) are supposed to get the right PDBs and make them available for their customers

solved. just have the pdbs where the dlls/libs are and have /PDBALTPATH set

(probably) Some writeup / mechanism to avoid having ports affected by an already running mspdbsrv.

whatever that means? (don't run different vcpkg's in parallel?)

…bs with meson writing same pdb)

Neumann-A · 2022-07-12T14:34:59Z

Seems there is a problem with the setup of boost-build incorrectly forwarding entries of environment variables since they are expand too early. %_PDB% needs to be forwarded to the tool and not expanded early by b2. @yurybura @ras0219-msft

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for boost-modular-build-helper have changed but the version was not updated
version: 1.79.0#5
old SHA: 93946fc40b519f0f9afe1b0d36985b2def25d4ab
new SHA: e210e66f1e6520fa5263b9f566609e513374dcb3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for openssl have changed but the version was not updated
version: 3.0.5
old SHA: 6f3d4db3ea7bcbac9c79e8beb24c0a33c4da3e96
new SHA: 460c419faa6eb2ca65322ce2f588c0f373a28eb9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for boost-modular-build-helper have changed but the version was not updated
version: 1.79.0#5
old SHA: 93946fc40b519f0f9afe1b0d36985b2def25d4ab
new SHA: e210e66f1e6520fa5263b9f566609e513374dcb3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for protobuf have changed but the version was not updated
version: 3.21.2
old SHA: 8ae2a5d57f7d3bf934e4d773406cd0a323600031
new SHA: c6a7e45402fe22bb71e681f6283b5c3b21886983
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for openssl have changed but the version was not updated
version: 3.0.5
old SHA: 6f3d4db3ea7bcbac9c79e8beb24c0a33c4da3e96
new SHA: 460c419faa6eb2ca65322ce2f588c0f373a28eb9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for boost-modular-build-helper have changed but the version was not updated
version: 1.79.0#5
old SHA: 93946fc40b519f0f9afe1b0d36985b2def25d4ab
new SHA: e210e66f1e6520fa5263b9f566609e513374dcb3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for protobuf have changed but the version was not updated
version: 3.21.2
old SHA: 8ae2a5d57f7d3bf934e4d773406cd0a323600031
new SHA: c6a7e45402fe22bb71e681f6283b5c3b21886983
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for openssl have changed but the version was not updated
version: 3.0.5
old SHA: 6f3d4db3ea7bcbac9c79e8beb24c0a33c4da3e96
new SHA: 460c419faa6eb2ca65322ce2f588c0f373a28eb9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 98f8d00e89fb6a8019c2045cfa1edbe9d92d3405 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 471b840..85851b4 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1698,7 +1698,7 @@
     },
     "crashpad": {
       "baseline": "2022-04-16",
-      "port-version": 1
+      "port-version": 2
     },
     "crashrpt": {
       "baseline": "1.4.3",
diff --git a/versions/c-/crashpad.json b/versions/c-/crashpad.json
index b24546a..96c762c 100644
--- a/versions/c-/crashpad.json
+++ b/versions/c-/crashpad.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "cf08f35fdc309088752764d4b7ec30b6595e7a1d",
+      "version-date": "2022-04-16",
+      "port-version": 2
+    },
     {
       "git-tree": "aa3803e8f14e1a0467a2aa509403d9fc8c56e159",
       "version-date": "2022-04-16",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for boost-modular-build-helper have changed but the version was not updated
version: 1.79.0#5
old SHA: 93946fc40b519f0f9afe1b0d36985b2def25d4ab
new SHA: e210e66f1e6520fa5263b9f566609e513374dcb3
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for protobuf have changed but the version was not updated
version: 3.21.2
old SHA: 8ae2a5d57f7d3bf934e4d773406cd0a323600031
new SHA: c6a7e45402fe22bb71e681f6283b5c3b21886983
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for openssl have changed but the version was not updated
version: 3.0.5
old SHA: 6f3d4db3ea7bcbac9c79e8beb24c0a33c4da3e96
new SHA: 460c419faa6eb2ca65322ce2f588c0f373a28eb9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 98f8d00e89fb6a8019c2045cfa1edbe9d92d3405 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 9ae5bfd..4f4e60d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -1698,7 +1698,7 @@
     },
     "crashpad": {
       "baseline": "2022-04-16",
-      "port-version": 1
+      "port-version": 2
     },
     "crashrpt": {
       "baseline": "1.4.3",
diff --git a/versions/c-/crashpad.json b/versions/c-/crashpad.json
index b24546a..96c762c 100644
--- a/versions/c-/crashpad.json
+++ b/versions/c-/crashpad.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "cf08f35fdc309088752764d4b7ec30b6595e7a1d",
+      "version-date": "2022-04-16",
+      "port-version": 2
+    },
     {
       "git-tree": "aa3803e8f14e1a0467a2aa509403d9fc8c56e159",
       "version-date": "2022-04-16",

Neumann-A · 2022-07-19T12:58:19Z

Hmm:

SUMMARY FOR x64-windows
    SUCCEEDED: 1792
    BUILD_FAILED: 15
    FILE_CONFLICTS: 1
    CASCADED_DUE_TO_MISSING_DEPENDENCIES: 11

To fix (buildtree in pdb path)

(most are probably qmake ports. )

93 matches for pdb files not found

…uild

…to_use_Zi # Conflicts: # ports/boost-modular-build-helper/CMakeLists.txt

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for openssl have changed but the version was not updated
version: 3.0.5
old SHA: 6f3d4db3ea7bcbac9c79e8beb24c0a33c4da3e96
new SHA: 460c419faa6eb2ca65322ce2f588c0f373a28eb9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for openssl have changed but the version was not updated
version: 3.0.5
old SHA: 6f3d4db3ea7bcbac9c79e8beb24c0a33c4da3e96
new SHA: 460c419faa6eb2ca65322ce2f588c0f373a28eb9
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
error: checked-in files for boost-modular-build-helper have changed but the version was not updated
version: 1.79.0#6
old SHA: dfc5c6283db1ff870c64cdbb4d6cd8d4585f9a4e
new SHA: cba482e3c777b1cd621bc61e763a9155ec0c1c8d
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

Broken Bot

Neumann-A added 5 commits July 11, 2022 12:47

reduce pipeline load

21d9c65

post/pre portfile includes

2211d43

trying to add Zi

d09d5c7

cmake_language magic to inject install rules

de92c9e

Zi magic.

c90ddc0

github-actions bot previously approved these changes Jul 11, 2022

View reviewed changes

don't use bin dir in static builds

7f95bec

Neumann-A dismissed github-actions[bot]’s stale review via 7f95bec July 11, 2022 12:43

github-actions bot previously approved these changes Jul 11, 2022

View reviewed changes

make sure pdbs exist before installing them

5409c28

Neumann-A dismissed github-actions[bot]’s stale review via 5409c28 July 11, 2022 13:33

github-actions bot previously approved these changes Jul 11, 2022

View reviewed changes

JackBoosY self-assigned this Jul 11, 2022

JackBoosY added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jul 11, 2022

JackBoosY reviewed Jul 11, 2022

View reviewed changes

scripts/toolchains/windows.cmake Outdated Show resolved Hide resolved

JackBoosY added invalid and removed category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed labels Jul 11, 2022

Fix parallel link jobs with meson ports. (cannot run parallel link jo…

77f562c

…bs with meson writing same pdb)

Neumann-A dismissed github-actions[bot]’s stale review via 77f562c July 11, 2022 21:03

github-actions bot previously approved these changes Jul 11, 2022

View reviewed changes

only one link job at a time for cmake

664e2fe

Neumann-A dismissed github-actions[bot]’s stale review via 664e2fe July 11, 2022 21:46

github-actions bot previously approved these changes Jul 11, 2022

View reviewed changes

use job pools correctly

b27e945

Neumann-A dismissed github-actions[bot]’s stale review via b27e945 July 12, 2022 07:59

github-actions bot previously approved these changes Jul 12, 2022

View reviewed changes

github-actions bot requested changes Jul 18, 2022

View reviewed changes

Neumann-A added 3 commits July 18, 2022 15:35

fix additional regex characters

9470123

fix protobuf

6423c89

filter files

7b1f89e

github-actions bot requested changes Jul 18, 2022

View reviewed changes

Neumann-A added 3 commits July 18, 2022 20:37

crashpad don't include toolchain

06762ab

build nmkae don't include toolchain

8494ba4

fix already installed search

aa85d23

github-actions bot requested changes Jul 18, 2022

View reviewed changes

fix typo

1ff1a87

github-actions bot requested changes Jul 18, 2022

View reviewed changes

Neumann-A added 2 commits July 19, 2022 12:28

minor fixes to the boost build helper

c688169

v db

9f5d571

Merge remote-tracking branch 'upstream/master' into fix_zi_in_boost_b…

262385c

…uild

This was referenced Jul 21, 2022

Toolchains are not setting up CMAKE_MODULE_LINKER_FLAGS #25917

Closed

[boost] Look for /Zi and other flags #25863

Merged

Neumann-A added 2 commits July 26, 2022 08:31

Merge remote-tracking branch 'upstream/master' into try_to_use_Zi

93ce164

Merge remote-tracking branch 'origin/fix_zi_in_boost_build' into try_…

557298e

…to_use_Zi # Conflicts: # ports/boost-modular-build-helper/CMakeLists.txt

github-actions bot requested changes Jul 26, 2022

View reviewed changes

fix copying of pdbs in boost-* ports

fdbf37f

github-actions bot previously requested changes Jul 26, 2022

View reviewed changes

dg0yt mentioned this pull request Aug 21, 2022

gdal:x64-windows-static - .lib produced doesn't seem to be same structure as 3.4.3 #26362

Closed

JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed and removed invalid labels Sep 16, 2022

JackBoosY assigned Cheney-W and unassigned JackBoosY Oct 14, 2022

Neumann-A closed this May 29, 2024

Osyotr mentioned this pull request Dec 9, 2025

[windows|toolchain] Try using /Zi #48778

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[windows|toolchain] Try using /Zi#25692

[windows|toolchain] Try using /Zi#25692
Neumann-A wants to merge 37 commits intomicrosoft:masterfrom
Neumann-A:try_to_use_Zi

Neumann-A commented Jul 11, 2022 •

edited

Loading

Uh oh!

Uh oh!

JackBoosY commented Jul 11, 2022

Uh oh!

Osyotr commented Jul 11, 2022

Uh oh!

Neumann-A commented Jul 11, 2022 •

edited

Loading

Uh oh!

Neumann-A commented Jul 12, 2022

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Neumann-A commented Jul 19, 2022

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Neumann-A commented Jul 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JackBoosY commented Jul 11, 2022

Uh oh!

Osyotr commented Jul 11, 2022

Uh oh!

Neumann-A commented Jul 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Neumann-A commented Jul 12, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Neumann-A commented Jul 19, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Neumann-A commented Jul 11, 2022 •

edited

Loading

Neumann-A commented Jul 11, 2022 •

edited

Loading